Fix-axios-version by Samk13 · Pull Request #1298 · inveniosoftware/invenio-communities

Samk13 · 2025-05-02T09:03:11Z

❤️ Thank you for your contribution!

Description

related to inveniosoftware/invenio-search-ui#215

Checklist

Ticks in all boxes and 🟢 on all GitHub actions status checks are required to merge:

I'm aware of the code of conduct.
I've created logical separate commits and followed the commit message format.
I've added relevant test cases.
I've added relevant documentation.
I've marked translation strings.
I've identified the copyright holder(s) and updated copyright headers for touched files (>15 lines contributions).
I've NOT included third-party code (copy/pasted source code or new dependencies).
- If you have added third-party code (copy/pasted or new dependencies), please reach out to an architect.

Frontend

I've followed the CSS/JS and React guidelines.
I've followed the web accessibility guidelines.
I've followed the user interface guidelines.

Reminder

By using GitHub, you have already agreed to the GitHub’s Terms of Service including that:

You license your contribution under the same terms as the current repository’s license.
You agree that you have the right to license your contribution under the current repository’s license.

Samk13 · 2025-05-04T19:19:58Z

Dependency resolution is failing on CI, while it works locally. I’ve tried various lower bounds combinations without success, e.g.:

install_requires =
    invenio-oaiserver>=2.4.0,<3.0.0
    invenio-requests>=4.1.0,<5.0.0
    invenio-search-ui>=2.9.0,<3.0.0
    invenio-vocabularies>=3.5.0,<4.0.0
    invenio-administration>=2.2.4,<3.0.0

[options.extras_require]
tests =
    pytest-black-ng>=0.4.0
    Faker>=2.0.3
    invenio-app>=1.5.1,<2.0.0
    invenio-db[postgresql,mysql]>=1.3.1,<2.0.0
    pytest-invenio>=2.2.1,<3.0.0
    sphinx>=4.5.0
opensearch1 =
    invenio-search[opensearch1]>=2.4.1,<3.0.0
opensearch2 =
    invenio-search[opensearch2]>=2.4.1,<3.0.0

utnapischtim · 2025-05-05T19:35:13Z

setup.cfg

-    invenio-administration>=2.0.0,<3.0.0
+    invenio-oaiserver>=2.4.0,<3.0.0
+    invenio-requests>=4.1.3,<5.0.0
+    invenio-search-ui>=2.9.1,<3.0.0


invenio-search-ui needs to be >=2.4.0, otherwise it conflicts with app-rdm

We can try that.

I tried all the ways here: https://pip.pypa.io/en/latest/topics/dependency-resolution/#reduce-the-number-of-versions-pip-is-trying-to-use but it looks like Any compatible version. syntax works!

tmorrell

Since this is needed to fix broken v12 installs.

setup.cfg

fenekku · 2025-05-06T12:56:37Z

setup.cfg

    invenio-search-ui>=2.4.0,<3.0.0
    invenio-vocabularies>=3.0.0,<4.0.0
-    invenio-administration>=2.0.0,<3.0.0
+    invenio-administration~=2.2.4


Have you tried adding invenio-records-resources>=5.10.0,<6.0.0 to that list? (something I am adding here #1294 ) It's directly used and makes sense to surface up one level.

Are we using this maint-v2.2.x branch?
https://github.com/inveniosoftware/invenio-administration/tree/maint-v2.2.x
it's confusing to have it there along with maint-v2.x, can we safely remove it?

reason why I am asking is when I check locally what version is been resolved its invenio-administration==2.2.4 while what we have latest on 2 is 2.11.0
could be the the resolver getting confused here? even though it should be looking for tag number when resolving.
I checked where administration is pinned in other packages but didn't find any. this is the last place to look for.

vocabularies
administration is not required here at this version, the newer tags is: https://github.com/inveniosoftware/invenio-vocabularies/blob/v3.5.0/setup.cfg

pages:
https://github.com/inveniosoftware/invenio-pages/blob/v4.1.2/setup.cfg#L42

Users-resources
https://github.com/inveniosoftware/invenio-users-resources/blob/maint-v6.x/setup.cfg#L30

banners
https://github.com/inveniosoftware/invenio-banners/blob/v3.3.1/setup.cfg#L30

communities:
https://github.com/inveniosoftware/invenio-communities/blob/v13.1.0/setup.cfg#L34

rdm-records:
https://github.com/inveniosoftware/invenio-rdm-records/blob/v10.9.2/setup.cfg#L42

Have you tried adding invenio-records-resources>=5.10.0,<6.0.0 to that list? (something I am adding here #1294 ) It's directly used and makes sense to surface up one level.

and it did not resolve:

The conflict is caused by: invenio-administration 2.0.0 depends on invenio-accounts<5.0.0 and >=4.0.0 invenio-records-resources 5.11.1 depends on invenio-accounts<6.0.0 and >=5.0.0 invenio-records-resources 5.10.1 depends on invenio-accounts<6.0.0 and >=5.0.0 invenio-records-resources 5.10.0 depends on invenio-accounts<6.0.0 and >=5.0.0

Changing to administration to ~=2.2.4 resolves.
and now it works without ~=🪄

invenio-oaiserver>=2.2.0,<3.0.0 invenio-requests>=4.0.0,<5.0.0 invenio-search-ui>=2.4.0,<3.0.0 invenio-vocabularies>=3.0.0,<4.0.0 invenio-administration>=2.0.0,<3.0.0 invenio-records-resources>=5.10.0,<6.0.0 # <-- the magic line

setup.cfg

* to fix issue: "Pip cannot resolve the current dependencies as the dependency graph is too complex for pip to solve efficiently."

* suppress known deprecation warnings in logs, e.g., '_app_ctx_stack' warning in Flask—migrated to 'g' or 'app_ctx' accordingly

fenekku

If tests pass again LGTM

Samk13 · 2025-05-06T14:29:22Z

If tests pass again LGTM

After merging this one, if any new issues arise, we’ll know exactly which PR to blame 😅

Samk13 force-pushed the fix-axios-version branch 6 times, most recently from f7e7c6a to 0d06619 Compare May 4, 2025 18:56

Samk13 force-pushed the fix-axios-version branch 5 times, most recently from 3f87ed6 to cf3a033 Compare May 5, 2025 15:13

utnapischtim reviewed May 5, 2025

View reviewed changes

Samk13 force-pushed the fix-axios-version branch from 5fce872 to 7e2e9c3 Compare May 6, 2025 10:28

dependencies: update axios to version 1.8.2

b389b2d

Samk13 force-pushed the fix-axios-version branch from 4368beb to 63bbc0f Compare May 6, 2025 10:36

tmorrell approved these changes May 6, 2025

View reviewed changes

Samk13 requested a review from utnapischtim May 6, 2025 10:49

utnapischtim reviewed May 6, 2025

View reviewed changes

setup.cfg Outdated Show resolved Hide resolved

Samk13 force-pushed the fix-axios-version branch 5 times, most recently from c91a834 to 1f7232c Compare May 6, 2025 12:14

fenekku reviewed May 6, 2025

View reviewed changes

Samk13 force-pushed the fix-axios-version branch 5 times, most recently from 4b62295 to b3c6861 Compare May 6, 2025 13:26

Samk13 force-pushed the fix-axios-version branch 3 times, most recently from 497e197 to 0eac447 Compare May 6, 2025 14:12

Samk13 added 2 commits May 6, 2025 16:19

installation: add records-resources to requirements

ecc5036

* to fix issue: "Pip cannot resolve the current dependencies as the dependency graph is too complex for pip to solve efficiently."

tests: disable warnings entirely

862c469

* suppress known deprecation warnings in logs, e.g., '_app_ctx_stack' warning in Flask—migrated to 'g' or 'app_ctx' accordingly

Samk13 force-pushed the fix-axios-version branch from 0161a68 to 862c469 Compare May 6, 2025 14:20

fenekku approved these changes May 6, 2025

View reviewed changes

📦 release: v13.1.1

c9b2bde

utnapischtim approved these changes May 6, 2025

View reviewed changes

max-moser approved these changes May 6, 2025

View reviewed changes

Samk13 merged commit 708ad7f into inveniosoftware:maint-13.x May 6, 2025
3 checks passed

Samk13 deleted the fix-axios-version branch May 6, 2025 14:43

Conversation

Samk13 commented May 2, 2025

Description

Checklist

Uh oh!

Samk13 commented May 4, 2025

Uh oh!

utnapischtim May 5, 2025

Choose a reason for hiding this comment

Uh oh!

Samk13 May 5, 2025

Choose a reason for hiding this comment

Uh oh!

Samk13 May 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

tmorrell left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

fenekku May 6, 2025

Choose a reason for hiding this comment

Uh oh!

Samk13 May 6, 2025

Choose a reason for hiding this comment

Uh oh!

Samk13 May 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Samk13 May 6, 2025

Choose a reason for hiding this comment

Uh oh!

Samk13 May 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

fenekku left a comment

Choose a reason for hiding this comment

Uh oh!

Samk13 commented May 6, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Samk13 May 6, 2025 •

edited

Loading

Samk13 May 6, 2025 •

edited

Loading

Samk13 May 6, 2025 •

edited

Loading